<html>
<head><meta charset="utf-8"><title>pr #61919 · wg-traits · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/index.html">wg-traits</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/pr.20.2361919.html">pr #61919</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="170649337"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/pr%20%2361919/near/170649337" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/pr.20.2361919.html#170649337">(Jul 11 2019 at 16:35)</a>:</h4>
<p><span class="user-mention" data-user-id="124069">@Alexander Regueiro</span> ok so I was reading into  Fix for "ambiguous associated type" issue with ATBs <a href="https://github.com/rust-lang/rust/issues/61919" target="_blank" title="https://github.com/rust-lang/rust/issues/61919">#61919</a>  -- I may take a stab at writing some comments again and push them to your branch. It's hard for me to summarize what's going on in any other way I think :)</p>



<a name="170655924"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/pr%20%2361919/near/170655924" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alexander Regueiro <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/pr.20.2361919.html#170655924">(Jul 11 2019 at 17:51)</a>:</h4>
<p>Sounds good</p>



<a name="170657646"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/pr%20%2361919/near/170657646" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alexander Regueiro <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/pr.20.2361919.html#170657646">(Jul 11 2019 at 18:11)</a>:</h4>
<p>Feel free to reinstate the hunk I reverted and comment it out actually -- but just fix it by swapping the pair <code>(def_id, None)</code> or whatever with <code>(None, def_id)</code> (so that the <code>impl_def_id</code> gets set rather than <code>trait_def_id</code>)</p>



<a name="170657652"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/pr%20%2361919/near/170657652" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alexander Regueiro <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/pr.20.2361919.html#170657652">(Jul 11 2019 at 18:11)</a>:</h4>
<p>but yeah, comments are good regardless!</p>



<a name="170711394"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/pr%20%2361919/near/170711394" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/pr.20.2361919.html#170711394">(Jul 12 2019 at 10:32)</a>:</h4>
<p>ok <span class="user-mention" data-user-id="124069">@Alexander Regueiro</span> see <a href="https://github.com/rust-lang/rust/pull/61919#pullrequestreview-261180520" target="_blank" title="https://github.com/rust-lang/rust/pull/61919#pullrequestreview-261180520">this review</a> -- something was bothering me so I investigated more deeply.</p>



<a name="170766194"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/144729-wg-traits/topic/pr%20%2361919/near/170766194" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alexander Regueiro <a href="https://rust-lang.github.io/zulip_archive/stream/144729-wg-traits/topic/pr.20.2361919.html#170766194">(Jul 13 2019 at 00:46)</a>:</h4>
<p>Makes sense. That same thing was bothering me too, but you got to the bottom of it, which is great. Will have a closer look soon!</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>